Skip to content

Fix combined mesh export transforms and child selection (v2.6.9)#188

Open
kyleyoungblom wants to merge 1 commit intopoly-hammer:combined-mesh-collision-transformsfrom
kyleyoungblom:fix/combined-mesh-collision-transforms
Open

Fix combined mesh export transforms and child selection (v2.6.9)#188
kyleyoungblom wants to merge 1 commit intopoly-hammer:combined-mesh-collision-transformsfrom
kyleyoungblom:fix/combined-mesh-collision-transforms

Conversation

@kyleyoungblom
Copy link
Copy Markdown

@kyleyoungblom kyleyoungblom commented Mar 3, 2026

Summary

  • Fixed EMPTY type check ('Ellipsis''EMPTY') so EMPTY parents are handled correctly in combined mesh exports
  • Fixed visual mesh transforms: use fbx_object_tx values with EMPTY position subtraction instead of incorrect world-delta calculations
  • Fixed collision primitive transforms (UBX/UCP/USP/UCX): compute clean local transform via fbx_object_matrix(global_space=True) to avoid contamination from EMPTY display transforms leaking through matrix_local parent correction path
  • Skip non-export-collection children in select_all_children to prevent boolean cutters and other non-export objects from being included in combined mesh exports
  • Guard select_set against objects not in the current View Layer

Test plan

  • Combined mesh export with EMPTY parent (no display transforms) — visual mesh + collisions
  • Combined mesh export with EMPTY parent with non-uniform display scale/rotation — visual mesh + collisions
  • Rotated instanced meshes parented to display-transformed EMPTY
  • Collision types: UCX (convex hull), UBX (box), USP (sphere)
  • Child collision parented to visual mesh (grandchild of EMPTY)
  • Root collision parented directly to EMPTY
  • Boolean cutter objects in non-export collection excluded from export
  • Objects outside View Layer don't cause crash

@jack-yao91
Copy link
Copy Markdown

jack-yao91 commented Mar 11, 2026

@kyleyoungblom at a glance this looks good, but I will need to pull it into one of the repo's own branches to run the test suite on it.

  1. Can you edit the PR so that it is going into the poly-hammer:combined-mesh-collision-transforms? (from there I can trigger the tests)
  2. Also, can you revert the changes you made to the README.md file.
  3. Any bug fix notes you can add to this file here

Thanks!

@jack-yao91 jack-yao91 changed the base branch from main to combined-mesh-collision-transforms March 11, 2026 20:01
@kyleyoungblom kyleyoungblom force-pushed the fix/combined-mesh-collision-transforms branch 4 times, most recently from eaee83f to f0a9911 Compare March 16, 2026 20:57
@kyleyoungblom kyleyoungblom changed the title Fix combined mesh export transforms for EMPTY root and collision primitives Fix combined mesh export transforms and child selection (v2.6.9) Mar 16, 2026
- Fix collision primitive transforms (position, rotation, scale) for
  combined mesh exports with EMPTY display transforms
- Fix visual mesh distortion when parent EMPTY has non-uniform
  scale/rotation set for display purposes
- Add EMPTY type check to prevent non-EMPTY parents from entering
  combined mesh path
- Skip child objects not in current View Layer to prevent selection error
- Filter non-export-collection children from combined mesh exports
@kyleyoungblom kyleyoungblom force-pushed the fix/combined-mesh-collision-transforms branch from f0a9911 to acc28f6 Compare March 30, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants